Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blowup along a ray does not change orbifoldness #4403

Merged

Conversation

paemurru
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (e7bcfba) to head (1ef6f3a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
experimental/Schemes/src/ToricBlowups/types.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4403      +/-   ##
==========================================
- Coverage   84.40%   84.40%   -0.01%     
==========================================
  Files         656      656              
  Lines       87247    87251       +4     
==========================================
+ Hits        73641    73644       +3     
- Misses      13606    13607       +1     
Files with missing lines Coverage Δ
experimental/Schemes/src/ToricBlowups/types.jl 72.30% <75.00%> (+0.17%) ⬆️

Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you for adding this.

@joschmitt joschmitt merged commit ddbce80 into oscar-system:master Dec 17, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants